Problem: nixpkgs and python dependencies are out of date #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
+ Coverage 30.08% 32.92% +2.84%
==========================================
Files 125 131 +6
Lines 20039 20164 +125
==========================================
+ Hits 6028 6640 +612
+ Misses 12965 12461 -504
- Partials 1046 1063 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mmsqe
reviewed
Feb 21, 2024
There was a problem hiding this comment.
do we need update go.mod and cleanup unused GOLANG_CROSS_VERSION?
|
do we need bump chainlibpy as well? |
mmsqe
reviewed
Feb 21, 2024
yihuang
commented
Feb 21, 2024
it seems easier to refactor the test case itself. |
mmsqe
approved these changes
Feb 21, 2024
Solution: - update nixpkgs to nixpkgs-unstable - rustc to 1.75 - update python dependencies in integration tests update go in workflows fix hdwallets trigger build, don't merge release workflow update govuln update go.mod fix go.mod add toolchain bump golangci-lint fix go lint fix nix lint Update app/app.go Signed-off-by: yihuang <huang@crypto.com> skip test_sign_offline for now fix skip fix ledger test fix py lint align version fix lint
Merged
via the queue into
crypto-org-chain:master
with commit Feb 21, 2024
e344315
33 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)