Problem: nixpkgs is not pinned properly #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
calvinaco,
devashishdxt,
leejw51crypto,
linfeng-crypto and
tomtau
as code owners
|
the ledger test fails @linfeng-crypto ? |
Solution: - use niv to manage nixpkgs and other dependencies - refactor nix expression a little bit
I think it's my fault, it's running with the chain-maind without ledger-zemu. |
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=======================================
Coverage 27.17% 27.17%
=======================================
Files 32 32
Lines 5773 5773
=======================================
Hits 1569 1569
Misses 4021 4021
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| @@ -146,8 +146,8 @@ clean-docker-compose: localnet-stop | |||
| ############################################################################### | |||
| # nix installation: https://nixos.org/download.html | |||
| nix-integration-test: check-network | |||
| nix-shell integration_tests/shell.nix --arg ci true --run "pytest -v -n 6 -m 'not ledger' --dist loadscope" | |||
| nix-shell integration_tests/shell.nix --arg ci true --run "pytest -v -m ledger" | |||
| nix-shell ./. -A ci-shell --run "pytest -v -n 7 -m 'not ledger' --dist loadscope" | |||
There was a problem hiding this comment.
what's meaning of ./.?
if it means current folder, how about $PWD for readibility?
There was a problem hiding this comment.
it's short for ./default.nix, I guess you can also use $PWD/.
| nixpkgs-fmt | ||
| ]; | ||
| } | ||
| run: nix-shell ./. -A lint-shell --run "make lint-ci" |
There was a problem hiding this comment.
how about nix-shell $PWD?
tomtau
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nixpkgs is only pinned with environment variable, better to use niv to manage.
Solution: