Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: integration with Hermes 0.6 is not tested #607

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Jul 28, 2021

Solution: upgraded pystarport due to breaking changes in Hermes
and nixkpgs (as Rust 1.53+ tooling is needed to build 0.6 Hermes)

Solution: upgraded pystarport due to breaking changes in Hermes
and nixkpgs (as Rust 1.53+ tooling is needed to build 0.6 Hermes)
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #607 (952951e) into master (16b4d7e) will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
+ Coverage   14.29%   14.69%   +0.39%     
==========================================
  Files          70       68       -2     
  Lines        9343     9243     -100     
==========================================
+ Hits         1336     1358      +22     
+ Misses       7661     7545     -116     
+ Partials      346      340       -6     
Flag Coverage Δ
integration_tests 14.69% <ø> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/docs/statik/statik.go 100.00% <0.00%> (ø)
x/nft/simulation/operations.go 0.00% <0.00%> (ø)
x/nft/types/denom.go
x/nft/types/codec.go
x/nft/types/validation.go
config/config.go 50.00% <0.00%> (ø)
x/nft/client/rest/tx.go 5.00% <0.00%> (+5.00%) ⬆️
x/nft/keeper/querier.go 14.75% <0.00%> (+7.23%) ⬆️
x/supply/types/key.go 33.33% <0.00%> (+13.33%) ⬆️
app/app.go 90.32% <0.00%> (+40.32%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b4d7e...952951e. Read the comment docs.

@tomtau tomtau merged commit 172205c into crypto-org-chain:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants