-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: memiavl is not integrated #989
Conversation
Solution: - integrate memiavl feature
Signed-off-by: yihuang <huang@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>
Codecov Report
@@ Coverage Diff @@
## master #989 +/- ##
==========================================
- Coverage 19.86% 14.83% -5.04%
==========================================
Files 250 128 -122
Lines 39972 20023 -19949
==========================================
- Hits 7940 2970 -4970
+ Misses 30865 16817 -14048
+ Partials 1167 236 -931
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just not sure if need add grocksdb_clean_link
it depends on user's local rocksdb library build, if static linking then no need, so it's alright in Makefile I think. |
5afc28e
to
bd760a5
Compare
68ede6f
to
e7a1e50
Compare
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)