Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: memiavl is not integrated #989

Merged
merged 9 commits into from
Jun 15, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 14, 2023

Solution:

  • integrate memiavl feature

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner June 14, 2023 02:19
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
app/config/toml.go Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #989 (f42a1e9) into master (8067492) will decrease coverage by 5.04%.
The diff coverage is 81.08%.

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   19.86%   14.83%   -5.04%     
==========================================
  Files         250      128     -122     
  Lines       39972    20023   -19949     
==========================================
- Hits         7940     2970    -4970     
+ Misses      30865    16817   -14048     
+ Partials     1167      236     -931     
Flag Coverage Δ
integration_tests ?
integration_tests_byzantine 9.65% <40.54%> (+0.04%) ⬆️
integration_tests_gov 10.06% <81.08%> (+0.23%) ⬆️
integration_tests_grpc 10.04% <81.08%> (+0.23%) ⬆️
integration_tests_ibc ?
integration_tests_ledger 9.85% <40.54%> (+0.04%) ⬆️
integration_tests_slow 9.85% <40.54%> (+0.04%) ⬆️
integration_tests_solomachine 9.65% <40.54%> (+0.04%) ⬆️
integration_tests_upgrade ?
unit_tests 10.97% <12.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 91.05% <12.50%> (+0.31%) ⬆️
app/config/config.go 100.00% <100.00%> (ø)
app/memiavl.go 100.00% <100.00%> (ø)
cmd/chain-maind/app/app.go 83.52% <100.00%> (+0.19%) ⬆️

... and 190 files with indirect coverage changes

Copy link
Contributor

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just not sure if need add grocksdb_clean_link

@yihuang
Copy link
Collaborator Author

yihuang commented Jun 14, 2023

LGTM, just not sure if need add grocksdb_clean_link

it depends on user's local rocksdb library build, if static linking then no need, so it's alright in Makefile I think.

@yihuang yihuang enabled auto-merge June 14, 2023 03:50
@yihuang yihuang disabled auto-merge June 15, 2023 08:24
@yihuang yihuang added this pull request to the merge queue Jun 15, 2023
@yihuang yihuang removed this pull request from the merge queue due to a manual request Jun 15, 2023
go.mod Outdated Show resolved Hide resolved
@yihuang yihuang enabled auto-merge June 15, 2023 14:49
@yihuang yihuang added this pull request to the merge queue Jun 15, 2023
Merged via the queue into crypto-org-chain:master with commit 7664c1f Jun 15, 2023
@yihuang yihuang deleted the memiavl-integration branch June 15, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants