Skip to content

Commit

Permalink
chore: remove semver as dev dependency (nodejs#2646)
Browse files Browse the repository at this point in the history
  • Loading branch information
Uzlopak authored and crysmags committed Feb 27, 2024
1 parent 4b591c5 commit 3f31f5b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@
"pre-commit": "^1.2.2",
"proxy": "^1.0.2",
"proxyquire": "^2.1.3",
"semver": "^7.5.4",
"sinon": "^17.0.1",
"snazzy": "^9.0.0",
"standard": "^17.0.0",
Expand Down
7 changes: 1 addition & 6 deletions test/http2.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,11 @@ const { Blob } = require('node:buffer')
const { Writable, pipeline, PassThrough, Readable } = require('node:stream')

const { test, plan } = require('tap')
const { gte } = require('semver')
const pem = require('https-pem')

const { Client, Agent } = require('..')

const isGreaterThanv20 = gte(process.version.slice(1), '20.0.0')
// NOTE: node versions <16.14.1 have a bug which changes the order of pseudo-headers
// https://github.com/nodejs/node/pull/41735
const hasPseudoHeadersOrderFix = gte(process.version.slice(1), '16.14.1')
const isGreaterThanv20 = process.versions.node.split('.').map(Number)[0] >= 20

plan(24)

Expand Down Expand Up @@ -1170,7 +1166,6 @@ test('Agent should support H2 connection', async t => {

test(
'Should provide pseudo-headers in proper order',
{ skip: !hasPseudoHeadersOrderFix },
async t => {
const server = createSecureServer(pem)
server.on('stream', (stream, _headers, _flags, rawHeaders) => {
Expand Down

0 comments on commit 3f31f5b

Please sign in to comment.