Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing space in Makefile #481

Merged

Conversation

straight-shoota
Copy link
Contributor

Unfortunately, GNU make does not chop off trailing whitespace from string values in assignments. So the default BINDIR was /usr/local /bin without this patch.

Fixes #479 (comment)

Unfortunately, GNU make does not chop off trailing whitespace from string
values in assignments. So the default BINDIR was `/usr/local /bin`
without this patch.
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sija Sija merged commit ca833ff into crystal-ameba:master Oct 11, 2024
2 of 4 checks passed
@Sija Sija added this to the 1.6.3 milestone Oct 11, 2024
@straight-shoota straight-shoota deleted the fix/makefile-trailing-space branch October 11, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants