validate boolean option in connection string. proper downcase.

crystal-lang · Dec 7, 2016 · da2831c · da2831c
1 parent 4721ecb
commit da2831c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/spec/db_spec.cr b/spec/db_spec.cr
@@ -107,5 +107,9 @@ describe DB do
 
     DB.fetch_bool(HTTP::Params.parse("bar=true"), "foo", false).should be_false
     DB.fetch_bool(HTTP::Params.parse("bar=true"), "foo", true).should be_true
+
+    expect_raises(ArgumentError, %(invalid "other" value for option "foo")) do
+      DB.fetch_bool(HTTP::Params.parse("foo=other"), "foo", true)
+    end
   end
 end
diff --git a/src/db.cr b/src/db.cr
@@ -123,10 +123,15 @@ module DB
 
   # :nodoc:
   def self.fetch_bool(params : HTTP::Params, name, default : Bool)
-    if value = params[name]?
-      value.underscore == "true"
-    else
+    case (value = params[name]?).try &.downcase
+    when nil
       default
+    when "true"
+      true
+    when "false"
+      false
+    else
+      raise ArgumentError.new(%(invalid "#{value}" value for option "#{name}"))
     end
   end
 end