Add exception handler in spec at_exit #10106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions bubbling up from at_exit handlers are printed without backtrace by default, but since the entire spec run happens in an at_exit handler, we should make sure to have full error reporting.
|
Singlehandedly +10% to productivity when porting things to Windows |
|
Can we change at_exit? |
|
Maybe... I'm not sure about the reasoning for not skipping the backtraces. It basically has been like this since forever. I just want to improve specs behaviour. Always printing backtraces from exit handlers would work for that. |
jhass
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions bubbling up from at_exit handlers are printed without backtrace by default, but since the entire spec run happens in an at_exit handler, we should make sure to have full error reporting.