Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling edge cases for Time::Location#load #10140

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Improve handling edge cases for Time::Location#load #10140

merged 2 commits into from
Jan 6, 2021

Conversation

straight-shoota
Copy link
Member

This patch makes sure that find_zoneinfo_file only returns readable files and read_zoneinfo raises InvalidTZDataError on any IOError.

@straight-shoota straight-shoota added this to the 1.0.0 milestone Dec 30, 2020
@asterite asterite merged commit 698aecc into crystal-lang:master Jan 6, 2021
@straight-shoota straight-shoota deleted the fix/time-location-load branch January 6, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:time
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.
3 participants
@straight-shoota @jhass @asterite