Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more literal types in use_yaml_discriminator #10149

Conversation

straight-shoota
Copy link
Member

Similar to #9222, but for YAML.

Because the raw YAML values of Nodes::Scalar are of type String, arbitrary literals already work with use_yaml_discriminator. This adds support for paths and adds the same specs as the JSON pendant.

@asterite asterite added this to the 1.0.0 milestone Jan 7, 2021
@asterite asterite merged commit 76768fe into crystal-lang:master Jan 7, 2021
@straight-shoota straight-shoota deleted the feature/use_yaml_discriminator-improve branch January 7, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants