Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when matching arguments against splat restriction after positional parameters #10172

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions spec/compiler/semantic/splat_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,16 @@ describe "Semantic: splat" do
)) { tuple_of([] of Type).metaclass }
end

it "uses splat restriction after non-splat arguments (#5037)" do
assert_type(%(
def foo(x, *y : *T) forall T
T
end

foo 1, 'a', ""
)) { tuple_of([char, string]).metaclass }
end

it "uses splat restriction with concrete type" do
assert_error %(
struct Tuple(T)
Expand Down
3 changes: 3 additions & 0 deletions src/compiler/crystal/semantic/method_lookup.cr
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,9 @@ module Crystal
unless match_arg_type
return nil
end

matched_arg_types ||= [] of Type
matched_arg_types.concat(splat_arg_types)
end

found_unmatched_named_arg = false
Expand Down