Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if I have installed an llvm-config that is newer than crystal yet sup… #10221

Merged
merged 3 commits into from
Jan 18, 2021

Conversation

rdp
Copy link
Contributor

@rdp rdp commented Jan 8, 2021

…ports, it says 'Could not locate llvm-config' even though it can locate it, it's just the wrong version, attempt fix message

…ports, it says 'Could not locate llvm-config' even though it can locate it, it's just the wrong version, attempt fix message
Makefile Outdated Show resolved Hide resolved
rdp and others added 2 commits January 15, 2021 16:19
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea from #10221 (comment) to factor the supported versions out to a file and include that here to show the versions directly.
This PR is fine by itself, so you can leave it like that and someone else may pick up the file idea.

@bcardiff bcardiff added this to the 0.36.0 milestone Jan 18, 2021
@bcardiff bcardiff merged commit 8aee002 into crystal-lang:master Jan 18, 2021
@rdp rdp deleted the unknown_llvm branch November 5, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants