Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NamedTuple instance restrictions in redefinition checks #10245

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Support NamedTuple instance restrictions in redefinition checks #10245

merged 1 commit into from
Jan 13, 2021

Conversation

HertzDevil
Copy link
Contributor

Fixes #10238.

asterite
asterite approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid! 👍

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels Jan 12, 2021
@straight-shoota straight-shoota added this to the 1.0.0 milestone Jan 12, 2021
@asterite asterite merged commit a0cbe63 into crystal-lang:master Jan 13, 2021
@HertzDevil HertzDevil deleted the bug/namedtuple-restriction branch January 13, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

NamedTuple type does not distinguish between names
3 participants
@HertzDevil @asterite @straight-shoota