Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --mcpu native #10264

Merged
merged 4 commits into from
Jan 18, 2021
Merged

Add support for --mcpu native #10264

merged 4 commits into from
Jan 18, 2021

Conversation

BlobCodes
Copy link
Contributor

Most GNU and LLVM-based compilers allow using the --mcpu native flag to tune the performance for the host cpu.

This patch adds support for passing this flag. It will get turned into the host CPU name.
For this, a LLVM#host_cpu_name method was added (because I didn't find a better place).

There are currently no specs as a test case would depend on the architecture of the machine running the specs.

This is my first contribution so feel free to notice me if there's something to improve.

@straight-shoota
Copy link
Member

Could you add this special value to the documentation in man/crystal.1, please?

@BlobCodes
Copy link
Contributor Author

Could you add this special value to the documentation in man/crystal.1, please?

Done!

@BlobCodes
Copy link
Contributor Author

Umm.. Now it is actually done.
Had some problems with my editor 😅.

@bcardiff bcardiff added this to the 0.36.0 milestone Jan 18, 2021
@bcardiff bcardiff merged commit d83d3e7 into crystal-lang:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants