Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset free vars before attempting each overload match #10271

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Reset free vars before attempting each overload match #10271

merged 2 commits into from
Jan 19, 2021

Conversation

HertzDevil
Copy link
Contributor

Fixes #10270. Fixes #10185 (comment).

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels Jan 19, 2021
@bcardiff bcardiff added this to the 0.36.0 milestone Jan 19, 2021
@bcardiff bcardiff merged commit 64c6a01 into crystal-lang:master Jan 19, 2021
@bcardiff
Copy link
Member

Thanks @HertzDevil, this is great 🎯 . Have you been studying the compiler for long? 😅

@HertzDevil HertzDevil deleted the bug/overload-reset-free-vars branch January 19, 2021 18:14
@HertzDevil HertzDevil mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

Compiler does not reset free vars after partially failed overload match
4 participants
@HertzDevil @bcardiff @asterite @straight-shoota