Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Windows PDB lookup relative to running executable #11493

Merged

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Nov 25, 2021

This PR makes it so that the debug database .pdb file is always searched in the same directory as the executable being run, instead of being hardcoded to the .pdb's absolute path at build time. This allows call stacks to work even when the executable is moved to a different location (but not if it is renamed), as long as the .pdb is also moved.

@straight-shoota straight-shoota added this to the 1.3.0 milestone Nov 25, 2021
@straight-shoota straight-shoota merged commit 07b2065 into crystal-lang:master Nov 26, 2021
@HertzDevil HertzDevil deleted the feature/windows-relative-pdb branch November 29, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants