Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for Array#- with different generic type arguments #12049

Merged
merged 4 commits into from
May 13, 2022

Conversation

straight-shoota
Copy link
Member

The specs only covered cases where receiver and argument both have the same generic type arguments. This adds some missing specs covering different types.

This is relevant in the context of #8893. Adding these specs makes sense whatever comes out of that, though.

spec/std/array_spec.cr Outdated Show resolved Hide resolved
spec/std/array_spec.cr Outdated Show resolved Hide resolved
spec/std/array_spec.cr Outdated Show resolved Hide resolved
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@beta-ziliani beta-ziliani added this to the 1.5.0 milestone May 12, 2022
@straight-shoota straight-shoota merged commit d00a3b3 into crystal-lang:master May 13, 2022
@straight-shoota straight-shoota deleted the spec/array-- branch May 13, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants