Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Range#sample(n) for integers and floats #12535

Merged
merged 12 commits into from
Oct 24, 2022
Merged

Optimize Range#sample(n) for integers and floats #12535

merged 12 commits into from
Oct 24, 2022

Commits on Sep 27, 2022

  1. Range: optimize Range#sample(n) for integer ranges

    @asterite @straight-shoota
    asterite authored and straight-shoota committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1527eba View commit details
    Browse the repository at this point in the history

  2. Range: enable Range#sample(n) to work for float ranges

    @asterite @straight-shoota
    asterite authored and straight-shoota committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    8743e57 View commit details
    Browse the repository at this point in the history

  3. Oops, forgot to pass random

    @asterite @straight-shoota
    asterite authored and straight-shoota committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    19c71de View commit details
    Browse the repository at this point in the history

  4. Simplify condition

    @asterite @straight-shoota
    asterite authored and straight-shoota committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    73930a6 View commit details
    Browse the repository at this point in the history

  5. Simplify and optimize range sampling

    @asterite @straight-shoota
    asterite authored and straight-shoota committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    d217842 View commit details
    Browse the repository at this point in the history

  6. Yet another way to write a condition... 

    ...that's probably optimized by LLVM anyway
    @asterite @straight-shoota
    asterite authored and straight-shoota committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    7164884 View commit details
    Browse the repository at this point in the history

  7. Use the old algorithm when n >= size // 4

    @asterite @straight-shoota
    asterite authored and straight-shoota committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    a73f2b7 View commit details
    Browse the repository at this point in the history

  8. Always raise on invalid range on sample(0)

    @asterite @straight-shoota
    asterite authored and straight-shoota committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    8b3784e View commit details
    Browse the repository at this point in the history

  9. Pass random to shuffle!

    @asterite @straight-shoota
    asterite authored and straight-shoota committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    22d85c2 View commit details
    Browse the repository at this point in the history

  10. Fix specs again

    @asterite @straight-shoota
    asterite authored and straight-shoota committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    42d8b51 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Apply polish

    @straight-shoota
    straight-shoota committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    3a49bd4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Merge branch 'master' into feature/range-sample-for-int-and-float

    @straight-shoota
    straight-shoota authored Oct 22, 2022
    Configuration menu
    Copy the full SHA
    8d95b5a View commit details
    Browse the repository at this point in the history