Don't spawn subprocess if codegen spec uses flags but not the prelude #14904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Aug 14, 2024
|
@HertzDevil CI is failing all over the place with segfaults. |
|
Yeah this depends on #14903 since that originally failing spec isn't touched here |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
runspec helper always spawns a subprocess if any compile-time flags are specified. In practice, the only specs using theflagsparameter are the ones for-Dstrict_multi_assignand the obsolete ones for-Dpreview_overloadin #7206, which all separately require the prelude anyway. (There is one outlier that is addressed in #14903.) This PR allows specs specifyingflagsbut not requiring the prelude to use LLVM's JIT.