Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for String#index, #rindex search for Char::REPLACEMENT #14946

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Add specs for String#index, #rindex search for Char::REPLACEMENT #14946

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03901b5
Add specs for `String#index`, `#rindex` search for `Char::REPLACEMENT`
straight-shoota Aug 26, 2024
55401e3
Update spec/std/string_spec.cr
straight-shoota Aug 28, 2024
4b2aa2f
Update spec/std/string_spec.cr
straight-shoota Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions spec/std/string_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,7 @@ describe "String" do
it { "bar".index('あ').should be_nil }
it { "あいう_えお".index('_').should eq(3) }
it { "xyz\xFFxyz".index('\u{FFFD}').should eq(3) }
it { "日\xFF語".index('\u{FFFD}').should eq(1) }

describe "with offset" do
it { "foobarbaz".index('a', 5).should eq(7) }
Expand All @@ -967,6 +968,8 @@ describe "String" do
it { "日本語日本語".index('本', 2).should eq(4) }
it { "xyz\xFFxyz".index('\u{FFFD}', 2).should eq(3) }
it { "xyz\xFFxyz".index('\u{FFFD}', 4).should be_nil }
it { "日本\xFF語".index('\u{FFFD}', 2).should eq(2) }
it { "日本\xFF語".index('\u{FFFD}', 3).should be_nil }

# Check offset type
it { "foobarbaz".index('a', 5_i64).should eq(7) }
Expand Down Expand Up @@ -1110,6 +1113,7 @@ describe "String" do
it { "日本語日本語".rindex('本').should eq(4) }
it { "あいう_えお".rindex('_').should eq(3) }
it { "xyz\xFFxyz".rindex('\u{FFFD}').should eq(3) }
it { "日\xFF語".rindex('\u{FFFD}').should eq(1) }

describe "with offset" do
it { "bbbb".rindex('b', 2).should eq(2) }
Expand All @@ -1124,6 +1128,8 @@ describe "String" do
it { "日本語日本語".rindex('本', 3).should eq(1) }
it { "xyz\xFFxyz".rindex('\u{FFFD}', 4).should eq(3) }
it { "xyz\xFFxyz".rindex('\u{FFFD}', 2).should be_nil }
it { "日本\xFF語".rindex('\u{FFFD}', 2).should eq(2) }
it { "日本\xFF語".rindex('\u{FFFD}', 1).should be_nil }

# Check offset type
it { "bbbb".rindex('b', 2_i64).should eq(2) }
Expand Down
Loading