Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't involve evloop after fork in System::Process.spawn (UNIX) #14974

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Don't involve evloop after fork in System::Process.spawn (UNIX) #14974

merged 6 commits into from
Sep 6, 2024

Commits on Sep 5, 2024

  1. Extract Crystal::System::FileDescriptor.system_pipe (UNIX)

    @ysbaddaden
    ysbaddaden committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d46c2bd View commit details
    Browse the repository at this point in the history

  2. Fix: avoid evloop after fork to report failures in Process.spawn (UNIX)

    @ysbaddaden
    ysbaddaden committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b17f5f9 View commit details
    Browse the repository at this point in the history

  3. Fix: don't involve evloop in System::Process.reopen_io (UNIX) 

    This is called after fork before exec to reopen the stdio. We can
leverage some abstractions (set blocking, unset cloexec) but musn't call
to methods that involve the evloop and would mess with the parent
evloop.
    @ysbaddaden
    ysbaddaden committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    41ba972 View commit details
    Browse the repository at this point in the history

  4. fixup! Fix: avoid evloop after fork to report failures in Process.spa… 

    …wn (UNIX)
    @ysbaddaden
    ysbaddaden committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3e9b195 View commit details
    Browse the repository at this point in the history

  5. fixup! Fix: avoid evloop after fork to report failures in Process.spa… 

    …wn (UNIX)
    @ysbaddaden
    ysbaddaden committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    72f968c View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from straight-shoota

    @ysbaddaden
    ysbaddaden committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    581a691 View commit details
    Browse the repository at this point in the history