Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exponent overflow in BigFloat#to_s for very large values #14982

Merged

Conversation

HertzDevil
Copy link
Contributor

This is similar to #14971 where the base-10 exponent returned by LibGMP.mpf_get_str is not large enough to handle all values internally representable by GMP / MPIR.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric labels Sep 6, 2024
@straight-shoota straight-shoota added this to the 1.14.0 milestone Sep 6, 2024
@straight-shoota straight-shoota merged commit b5f2468 into crystal-lang:master Sep 10, 2024
63 of 65 checks passed
@HertzDevil HertzDevil deleted the bug/mpir-bigfloat-exp-overflow branch September 10, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants