Accept IO objects as HTTP request bodies #2096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass now. |
| @@ -80,7 +80,7 @@ struct OAuth::Signature | |||
| body = request.body | |||
| content_type = request.headers["Content-type"]? | |||
| if body && content_type == "application/x-www-form-urlencoded" | |||
| params.add_query body | |||
| params.add_query body.to_s | |||
There was a problem hiding this comment.
Shouldn't this rather raise if it's an IO, or at least read it?
There was a problem hiding this comment.
Oh my bad, I thought to_s returned the entire content as a String but this seems to be only the case for MemoryIO and not File etc. I believe the most intuitive thing is that we read it without raising an error.
|
This is a good change, we forgot about request's body being able to be an IO. We should also think if we want to have an IO in the server, so I guess this will need some more thought from our side. |
|
This was implemented in #3406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only strings (or nil) would have been accepted by the
HTTP::Client.execmethods.