Implement blocking ::sleep for win32 #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
force-pushed
the
feature/windows-sleep
branch
from
a7ca356
to
ad888bc
Compare
wooster0
approved these changes
Apr 14, 2018
ysbaddaden
reviewed
Apr 15, 2018
|
@ysbaddaden thats why it's in the windows stubs file - we have no scheduler, no fibers, no event loop, so the only thing we can do with sleep I on windows is stub it out temporarily to call blocking sleep. I guess the commit message is a bit weird though. |
|
@RX14 how about renaming title / commit message to |
asterite
approved these changes
Apr 15, 2018
chris-huxtable
pushed a commit
to chris-huxtable/crystal
that referenced
this pull request
Jun 6, 2018
Just calls LibC.Sleep for now, which blocks the whole program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.