-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP::Server#bind_unix #5959
Merged
RX14
merged 2 commits into
crystal-lang:master
from
straight-shoota:jm/feature/http-server-unix
Apr 18, 2018
Merged
Add HTTP::Server#bind_unix #5959
RX14
merged 2 commits into
crystal-lang:master
from
straight-shoota:jm/feature/http-server-unix
Apr 18, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
requested changes
Apr 17, 2018
spec/std/http/server/server_spec.cr
Outdated
@@ -310,6 +329,42 @@ module HTTP | |||
end | |||
end | |||
end | |||
|
|||
{% if flag?(:unix) %} | |||
describe "#bind_unix" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent
spec/std/http/server/server_spec.cr
Outdated
# TODO: replace with `HTTP::Client` once it supports connecting to Unix socket. | ||
private def unix_request(path) | ||
UNIXSocket.open(path) do |io| | ||
io << "GET / HTTP/1.1\r\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it shorter to use HTTP::Request
directly here?
RX14
approved these changes
Apr 18, 2018
jhass
approved these changes
Apr 18, 2018
sdogruyol
approved these changes
Apr 18, 2018
chris-huxtable
pushed a commit
to chris-huxtable/crystal
that referenced
this pull request
Jun 6, 2018
* Add HTTP::Server#bind_unix * fixup! Add HTTP::Server#bind_unix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one half of #2735 and follows up on #5776