-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec: allow --link-flags to be used #6243
Spec: allow --link-flags to be used #6243
Conversation
|
they make sense yes, but is there a use case for that? |
What is the |
@bcardiff when you need extra link flags to make an executable run at all? Perhaps you just want to run a quick snippet like Why not allow it, if it's pretty much easier to allow it than disallow it, by placing the option where the rest of the shared compiler flags are anyway? |
Oh, I misread the OP. I thought you were keeping |
Fix #6231 .
The
--link-flags
is not added in thesetup_simple_compiler_options
because setting thecompiler.link_flags
is done after theOptionParser.parse
.Nevertheless the
setup_simple_compiler_options
is used forcrystal eval
andcrystal spec
only.I don't think
--link-flags
are needed foreval