Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: type var that resolves to number in restriction didn't work #6504

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Fix: type var that resolves to number in restriction didn't work #6504

merged 1 commit into from
Aug 8, 2018

Conversation

asterite
Copy link
Member

@asterite asterite commented Aug 8, 2018

Fixes #6502

This got broken by #3972

I don't know why but some code I wrote got commented in that commit, probably an accident.

@sdogruyol sdogruyol added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler labels Aug 8, 2018
sdogruyol
sdogruyol approved these changes Aug 8, 2018
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asterite 👍

@bcardiff bcardiff merged commit cd8334d into crystal-lang:master Aug 8, 2018
@bcardiff bcardiff added this to the 0.26.0 milestone Aug 8, 2018
@bcardiff bcardiff mentioned this pull request Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@asterite @sdogruyol @bcardiff