Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: give parser error when assigning a constant inside a multiassign #7468

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Compiler: give parser error when assigning a constant inside a multiassign #7468

merged 1 commit into from
Feb 21, 2019

Conversation

asterite
Copy link
Member

Fixes #7428

I also renamed a method name because it was a bit cryptic.

@asterite asterite added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels Feb 21, 2019
@straight-shoota straight-shoota changed the title Compiler: give pare error when assigning a constant inside a multiassign Compiler: give parser error when assigning a constant inside a multiassign Feb 21, 2019
@asterite asterite added this to the 0.28.0 milestone Feb 21, 2019
@asterite asterite merged commit 2ae0c29 into crystal-lang:master Feb 21, 2019
@asterite asterite deleted the bug/parse-constant-in-multiassign branch March 30, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@asterite @ysbaddaden @straight-shoota