Compiler: fix a couple of issues with as, as? and unions
#7475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
straight-shoota
approved these changes
Feb 22, 2019
|
@ysbaddaden hehe, yes, thanks! Eventually the compiler could be simplified, improved and documented a bit more so these changes aren't that cryptic :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5805
Fixes #7441
The first two commits use
.type?instead of.typeon a couple of nodes because their types might not be computed yet.The third commit makes computing a union's type reactive (make it depend on the inner types, and if they change, recompute) and also use
.type?instead of.typebecause of the same reason as above.