Link MSVC runtime dynamically #9278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the way recommended for most uses and also a better default because the alternative breaks defaults when building any other library to link with (as evidenced by the simplification of the CI config). But this will mean the built executables will have this DLL dependency.
RX14
reviewed
May 11, 2020
| @@ -1,5 +1,5 @@ | |||
| {% if flag?(:win32) %} | |||
| @[Link("libcmt")] | |||
| @[Link("msvcrt")] | |||
There was a problem hiding this comment.
I think there should be a -Dwin_MT to link libcmt for those that want to use /MT builds.
There was a problem hiding this comment.
Probably. But not sure I like that exact name and approach to choosing this option.
But it is true that this is different from --static.
(Wait, does that one even apply to Windows? It's *.lib either way? And I think we've been linking statically without --static)
|
Egh you know what, it's quite a nice "side effect" that currently any executable built just from Crystal stdlib is fully self-contained. So I don't want to change the default anymore, maybe let's just make this overridable for people who need it. (still looking for ideas about a nice flag name or such). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the best practice and also a better default, because the alternative contradicts the defaults when building any other library to link with (as evidenced by the simplification of the CI config).
But this will mean the built executables will have this DLL dependency.