-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup YAML/JSON Any#dig methods #9415
Conversation
Do you mind applying the same to datum? |
Interesting this |
Internal and I wanted to avoid early generalization. It was used in log's config and context. But config was never merged in the end. |
We can let this as-is for now then. All tests pass, except the darwin test was canceled; don't know why. Note: I cannot view Circle CI logs anymore, it redirects to https://circleci.com/vcs-authorize/ (?!) :( |
Any#[] always return an Any, so it is always diggable. This also means the exception is superfluous.
c5d210a
to
7a409a0
Compare
Is it possible to move forward on this? |
Any#[] always return an Any, so it is always diggable.
This also means the exception is superfluous.
The logic inside the methods is also simplified, and return types added.