Enable large-file support on i386-linux-gnu #9478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without large-file support `File.open`, `File.info`, `Dir#read` fail for files whose size is larger than 2G or whose inode number is larger than 4G on 32-bit linux. This commit enables large-file support by using type definitions, function names and structure members when _FILE_OFFSET_BITS=64 is defined in C.
jhass
approved these changes
Jun 14, 2020
jhass
added
kind:bug
|
I'm just curious, if you don't mind: Do you still use a 32bit system in 2020? If so, can you tell me a bit about it and what you use it for? :) |
No. I have not used i386-linux for several years. I made this patch to check large-file support in crystal, which may be needed on arm-linux-gnueabihf. FYI, when 32-bit system is not limited to i386, x32 ABI seems usable in extreme benchmarking. |
|
Huh, first time I hear the term extreme bechmarking :D Searched a bit and I'm still not sure what it is... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9463, #9297 (comment)
Without large-file support
File.open,File.info,Dir#readfail for files whose size is larger than 2G or whose inode number is larger than 4G on 32-bit linux.This commit enables large-file support by using type definitions, function names and structure members when
_FILE_OFFSET_BITS=64is defined in C.