Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of HTTP::Server::Response#closed? to Bool #9489

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix type of HTTP::Server::Response#closed? to Bool #9489

merged 1 commit into from
Jun 23, 2020

Conversation

straight-shoota
Copy link
Member

Without this, the type of @closed and #closed? is Bool | Nil.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:networking labels Jun 16, 2020
@jhass jhass added the pr:ready-to-merge The changes are good to go, we need to triage merging it. label Jun 16, 2020
@j8r
Copy link
Contributor

j8r commented Jun 16, 2020

Hum, could be getter? closed : Bool = false then.

@jhass jhass removed the pr:ready-to-merge The changes are good to go, we need to triage merging it. label Jun 23, 2020
@jhass jhass added this to the 1.0.0 milestone Jun 23, 2020
@jhass jhass merged commit e75e429 into crystal-lang:master Jun 23, 2020
@straight-shoota straight-shoota deleted the fix/http_server_response-closed-bool branch June 23, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:networking
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.
3 participants
@straight-shoota @j8r @jhass