Compiler: implement autocasting in a better way #9501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
force-pushed
the
feature/automatic-casting-for-real
branch
from
d63d454
to
9e9e9d2
Compare
|
Nice! Does this also fix #8973 ? |
|
@jwoertink No, that has nothing to do with autocasting. #8973 can't be fixed without a major overhaul to how methods are looked up. And even then, I'm not sure how it should work. So it needs a bit more "thinking" time before it can be fixed. Not from the implementation side, but the actual semantics. |
|
CI is happy 🎉 |
waj
approved these changes
Jul 3, 2020
asterite
force-pushed
the
feature/automatic-casting-for-real
branch
from
9e9e9d2
to
e423bcc
Compare
|
@waj Thanks! I rebased this branch against master just to make sure CI passes... CI also seemed stuck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought of a better, more resilient way to implement autocasting. This removes the existing hacks around it.
I added a big chunk of comment explaining how this is currently done, and what
with_literalsandanalyze_allmeans, with a bunch of examples.Makes #9492 obsolete.