Win CI: Avoid looking for globally installed libs #9507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not an expected dependency and they're linked differently, causing problems
straight-shoota
approved these changes
Jun 18, 2020
|
Woops I had previously pushed an older commit with a failed approach. Now good. |
jhass
approved these changes
Jun 18, 2020
jhass
added
kind:bug
bcardiff
removed
the
pr:ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not an expected dependency and they're linked differently, causing problems.
Currently the problem appears if any of Crystal's direct dependency libs itself has an optional dependency on zlib. CMake "intelligently" finds it in "C:/Program Files/PostgreSQL/12/lib/zlib.lib" somehow.
And indeed, libpcre has an optional dependency on zlib.
(And I just add the same option everywhere, for good measure)
This became silently broken due to some change in the environment of GitHub Actions, and would be continuously failing on master, if not for the caching of the libs.
https://github.com/oprypin/crystal/runs/786065713 is a run on unmodified master but cache is cold in my repo so you can observe the failure there.
In particular, line 53 and line 239 of libpcre compilation.