Add Socket::IPAddress#private? #9517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this method ❤️ |
bcardiff
approved these changes
Jun 22, 2020
straight-shoota
approved these changes
Nov 21, 2020
Sija
reviewed
Nov 22, 2020
Comment on lines
278
to
300
|
|
||
| it "does not break when referencing lib type (#9928)" do | ||
| program = semantic("lib LibFoo; BAR = 0; end", wants_doc: true).program | ||
| generator = Doc::Generator.new(program, [""]) | ||
|
|
||
| # TODO: There should not be a link to LibFoo::Bar in the first place | ||
| # because LibFoo is undocumented | ||
| assert_code_link(generator.type(program), "LibFoo::BAR", %(<a href="LibFoo.html#BAR">LibFoo::BAR</a>)) | ||
| end |
There was a problem hiding this comment.
@straight-shoota Looks like a botched merge.
There was a problem hiding this comment.
Let's throw all that out with a git rebase -i, leaving only the original commit.
There was a problem hiding this comment.
Sorry for the mess. I made a hard reset and a clean merge of master.
straight-shoota
force-pushed
the
ipaddr-private
branch
from
9d22f1e
to
e8a3b40
Compare
Sija
reviewed
Nov 23, 2020
straight-shoota
approved these changes
Dec 4, 2020
|
This needs a rebase / conflict merge before merging. @jgillich if you prefer to hand off this, since it's been a while, please drop a comment. |
jgillich
force-pushed
the
ipaddr-private
branch
2 times, most recently
from
5cfd560
to
19892da
Compare
jgillich
force-pushed
the
ipaddr-private
branch
from
19892da
to
b510632
Compare
|
@bcardiff rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported over from the ruby method with the same name.