Fix bug with passing many args then a struct in Win64 C lib ABI #9520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a compilation spec for it -- which actually fails on x86_64!
asterite
approved these changes
Jun 20, 2020
jhass
added
kind:bug
jhass
approved these changes
Jun 20, 2020
jhass
added
the
pr:ready-to-merge
bcardiff
removed
the
pr:ready-to-merge
bcardiff
reviewed
Jun 22, 2020
| @@ -84,6 +84,36 @@ describe "Code gen: C ABI" do | |||
| ), &.to_i.should eq(6)) | |||
| end | |||
|
|
|||
| {% if flag?(:x86_64) && !flag?(:win32) %} | |||
| pending "passes struct after many other args (for real) (#9519)" | |||
There was a problem hiding this comment.
Why the spec does not apply on non-windows platform?
There was a problem hiding this comment.
Because it's broken there too, but a bit harder to fix (and maybe arguably out of scope here, wanting to fix it for the windows ABI).
The actual spec is below and enabled for windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a compilation spec for it (which actually fails on x86_64! -- see #9519)
The fix was suggested by @jhass and directly mirrors the change in #9430. The same mistake supposedly spread from the original Rust code which has since been fixed.
Chat conversation
Real function that led me to find this problem