Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C ABI: Add a spec for accepting a large struct - failing on win32, aarch64 #9534

Merged
merged 2 commits into from
Oct 27, 2020
Merged

C ABI: Add a spec for accepting a large struct - failing on win32, aarch64 #9534

merged 2 commits into from
Oct 27, 2020

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Jun 22, 2020

@oprypin oprypin mentioned this pull request Jun 22, 2020
Closed
@oprypin
Copy link
Member Author

oprypin commented Jun 22, 2020

(but this can be merged anyway because it's also a good spec to have on other platforms, where it's currently passing)

@jhass jhass added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform labels Jun 29, 2020
@bcardiff
Copy link
Member

@oprypin may I request a rebase of this PR due to conflicts?

@oprypin
Copy link
Member Author

oprypin commented Oct 26, 2020

Done

@bcardiff bcardiff added this to the 1.0.0 milestone Oct 26, 2020
@bcardiff bcardiff merged commit 70413c8 into crystal-lang:master Oct 27, 2020
@ggiraldez ggiraldez mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oprypin @bcardiff @jhass