Parser: fix a-b -c incorrectly parsed as a - (b - c)
#9652
Conversation
asterite
force-pushed
the
bug/plus-or-minus-after-var-is-always-var
branch
from
665fb7b
to
c1289a0
Compare
| Assign.new("c".var, 3.int32), | ||
| Call.new(Call.new("a".var, "-", "b".var), "-", "c".var), | ||
| ]) | ||
| it_parses "a = 1; b = 2; c = 3; a-b -c", Expressions.new([ |
There was a problem hiding this comment.
I suppose you wanted to change this to +es :)
There was a problem hiding this comment.
No, the difference is there's a space
There was a problem hiding this comment.
Ah. How about specs for + then? :D
| while current_char.ascii_whitespace? | ||
| next_char_no_column_increment | ||
| end | ||
| comes_plus_or_minus = current_char == '+' || current_char == '-' |
There was a problem hiding this comment.
| comes_plus_or_minus = current_char == '+' || current_char == '-' | |
| comes_plus_or_minus = current_char.in?('+', '-') |
|
Closing because I'm not sure this is the best way to solve this. |
|
@asterite Perhaps it's not the best but it works, so why to throw the baby with the bathwater? |
|
Nope |
|
Feel free to open a PR with this diff, I won't babysit it. |
|
There should still be a bug report for this. |
|
I think this one should be merged before 1.0 |
asterite
added
breaking-change
kind:bug
There was a problem hiding this comment.
The fix seems good enough to me. I've been validating with ast_helper a couple of expressions, trying to break things, but all seems good 👍 .
Fixes https://forum.crystal-lang.org/t/results-of-a-b-c-and-a-b-c-different/2402