Format: reduce redundant newlines at end of begin ... end
#9741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makenowjust
changed the title
begin ... endbegin ... end
jhass
approved these changes
Sep 11, 2020
Sija
reviewed
Sep 11, 2020
Follow up crystal-lang#9722 The following example still invokes a formatter issue like crystal-lang#9657. ``` begin 1 # Comment end ``` This commit fixes such issues.
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
makenowjust
force-pushed
the
format-begin-end-comment
branch
from
6528950
to
1468987
Compare
|
Resolved conflict. |
straight-shoota
approved these changes
Nov 21, 2020
straight-shoota
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #9722
The following example still invokes a formatter issue like #9657.
This PR fixes such issues.