Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP::Client logging and basic instrumentation #9756

Merged
merged 4 commits into from
Sep 25, 2020
Merged

Add HTTP::Client logging and basic instrumentation #9756

merged 4 commits into from
Sep 25, 2020

Commits on Sep 18, 2020

  1. Add HTTP::Client logging and basic instrumentation 

    This adds protected methods HTTP::Client#before_exec and #after_exec that can be used to hook into the lifecycle of the http client.

A first utility for this is adding a http.client log source to know a request is starting.

This enables some basic instrumentation to monitor the activity of the application without monkey patching sensitive parts of the http client
    @bcardiff
    bcardiff committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    534cc0c View commit details
    Browse the repository at this point in the history

  2. Replace with use def_around_exec macro

    @bcardiff
    bcardiff committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    f98d898 View commit details
    Browse the repository at this point in the history

  3. Manually expand macro to allow simple usage of def_around_exec

    @bcardiff
    bcardiff committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    46d4fd8 View commit details
    Browse the repository at this point in the history

  4. Add docs

    @bcardiff
    bcardiff committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    892428e View commit details
    Browse the repository at this point in the history