Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect failures in Nix build environment #9776

Merged
merged 3 commits into from
Sep 29, 2020

Conversation

bcardiff
Copy link
Member

Follow up #9727

I messed up a bit in the bin/ci changes and the exit status was lost.

After fixing that, I got stuck with an http/client/client_spec.cr that is failing when using the compiled compiler in nix environment. But it only fails when executed with other specs. Alone it works fine. The failure I'm seens is Failed to raise an exception: END_OF_STACK.. For now I am disabling that spec on darwin, I was unable to diagnose further the reason.

I also find that git was missing in nix-shell --pure environments.

@bcardiff bcardiff merged commit c095449 into crystal-lang:master Sep 29, 2020
@bcardiff bcardiff added this to the 1.0.0 milestone Sep 29, 2020
@bcardiff bcardiff deleted the check-build branch September 29, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants