Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving File#fsync, File#flock_exclusive, File#flock_shared, and File#flock_unlock methods to IO::FileDescriptor - Fixes #9793 #9794

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Moving File#fsync, File#flock_exclusive, File#flock_shared, and File#flock_unlock methods to IO::FileDescriptor - Fixes #9793 #9794

merged 2 commits into from
Oct 26, 2020

Conversation

naqvis
Copy link
Contributor

@naqvis naqvis commented Oct 3, 2020

Moved File#fsync, File#flock_exclusive, File#flock_shared, File#flock_unlock to IO::FileDescriptor
#9793 (comment)

asterite
asterite reviewed Oct 3, 2020
View reviewed changes
src/io/file_descriptor.cr Outdated Show resolved Hide resolved
naqvis
naqvis commented Oct 3, 2020
View reviewed changes
Copy link
Contributor Author

@naqvis naqvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Changes File to File Descriptor in comments.

@oprypin
Copy link
Member

oprypin commented Oct 3, 2020

Please change the title of this PR, right now it's basically empty.

@naqvis naqvis changed the title Fixes #9793 Moving File#fsync, File#flock_exclusive, File#flock_shared, and File#flock_unlock methods toIO::FileDescriptor - Fixes #9793 Oct 3, 2020
@naqvis
Copy link
Contributor Author

naqvis commented Oct 3, 2020

Please change the title of this PR, right now it's basically empty.

Thank you @oprypin. Changed title to match with issue heading

@naqvis naqvis changed the title Moving File#fsync, File#flock_exclusive, File#flock_shared, and File#flock_unlock methods toIO::FileDescriptor - Fixes #9793 Moving File#fsync, File#flock_exclusive, File#flock_shared, and File#flock_unlock methods to IO::FileDescriptor - Fixes #9793 Oct 3, 2020
bcardiff
bcardiff approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually the specs for IO::FileDescriptor should get more populated and check that we can use non files descriptors with these operations.

@bcardiff bcardiff added this to the 1.0.0 milestone Oct 6, 2020
@bcardiff bcardiff merged commit 40211f1 into crystal-lang:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib:files
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.
4 participants
@naqvis @oprypin @asterite @bcardiff