Rework dwarf eager loading (follow up to #9792) #9852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On preview_mt the specs are hang unless the initialization is changed
asterite
approved these changes
Oct 26, 2020
carlhoerberg
pushed a commit
to carlhoerberg/crystal
that referenced
this pull request
Nov 18, 2020
…lang#9852) * Make load_dwarf public but :nodoc: and introduce load_dwarf_impl * Move load_dwarf call to kernel On preview_mt the specs are hang unless the initialization is changed * Do not load dwarf on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialization included in #9792 causes the spec in preview_mt to hang. I was able to reproduce this locally with small programs, but not in a consistent manner.
I moved the
load_dwarfcall to kernel, which is a better place for it to be. That seems enough to avoid the problem introduced in #9792.Since
load_dwarfneeded to be public (yet :nodoc:) I refactored a bit the code to use@@dwarf_loadedonly indwarf.crand not inelf|mach_o.cr