Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9715: BigDecimal.to_s #9897

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

dukenguyenxyz
Copy link
Contributor

@dukenguyenxyz dukenguyenxyz commented Nov 8, 2020

  • Make BigFloat's negative decimal fractions after converting to string .to_s conform to stdlib's float-like number structs' (Float32, Float64, BigDecimal) norm (e.g. "-0.23" instead of the anomalous "-.21")

  • Fixes BigDecimal to_s bug #9715

  • For a full explanation, please view this comment BigDecimal to_s bug #9715 (comment)

@bcardiff bcardiff added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric labels Nov 9, 2020
@bcardiff bcardiff added this to the 1.0.0 milestone Nov 9, 2020
@bcardiff bcardiff merged commit 3a1f06d into crystal-lang:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigDecimal to_s bug
3 participants