Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use name: nightly in docs-versions.sh for HEAD #9915

Merged

Conversation

straight-shoota
Copy link
Member

At the time when this list is generated (at release), src/VERSION is
typically equivalent to the most recent tagged version.
It's better to just call it master and not present the development version.

This is what the top of the generated versions select currently looks like (for 0.35.1):

<option value="/api/master/" selected="true" disabled="true">0.35.1</option>
<option value="/api/0.35.1/" selected="true" disabled="true">0.35.1</option>

This is what it looks like after this patch:

<option value="/api/master/">master</option>
<option value="/api/0.35.1/" selected="true" disabled="true">0.35.1</option>

At the time when this list is generated (at release), `src/VERSION` is
typically equivalent to the most recent tagged version.
It should just be called master and not present the development version
(which may even change during its course).
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:docs-generator labels Nov 14, 2020
scripts/docs-versions.sh Outdated Show resolved Hide resolved
Co-authored-by: Jonne Haß <me@jhass.eu>
@straight-shoota straight-shoota added this to the 1.0.0 milestone Nov 26, 2020
@straight-shoota straight-shoota changed the title Use name: master in docs-versions.sh for HEAD Use name: nightly in docs-versions.sh for HEAD Nov 26, 2020
@bcardiff bcardiff merged commit ef80450 into crystal-lang:master Dec 1, 2020
@straight-shoota straight-shoota deleted the fix/docs-versions-master branch December 1, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:docs-generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants