Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider port to windows? #31

Closed
zw963 opened this issue May 7, 2023 · 2 comments · Fixed by #33
Closed

Consider port to windows? #31

zw963 opened this issue May 7, 2023 · 2 comments · Fixed by #33

Comments

@zw963
Copy link

zw963 commented May 7, 2023

Please check following issue too.

crystal-lang/crystal#5430 (comment)

Thanks
@zw963
Copy link
Author

zw963 commented May 12, 2023 •
edited
Loading

I add my app workflow for windows, get following error.

In lib\selenium\src\selenium\service.cr:99:20

 99 | process.signal(Signal::KILL)

                     ^-----------
Error: undefined constant Signal::KILL

this is the log.

Following is the portable advice for Signal.

https://crystal-lang.org/api/1.8.1/Signal.html#portability

@jwoertink jwoertink mentioned this issue Jun 28, 2023
Merged
@jwoertink
Copy link
Contributor

I just got this too on crystal-loot/exception_page#40

jwoertink added a commit that referenced this issue Jun 29, 2023
@jwoertink
Fixing compilation error on Windows. Also updates the CI to include W…
f99cda2 
…indows. Fixes #31
@jwoertink jwoertink mentioned this issue Jun 29, 2023
Merged
jwoertink added a commit that referenced this issue Jul 1, 2023
@jwoertink
Fixing compilation error on Windows. (#33)
cafdff4 
* Fixing compilation error on Windows. Also updates the CI to include Windows. Fixes #31

* bump ameba. It was locking up while building on windows, but maybe it was the version

* See if we can skip the ameba postinstall during specs

* Install Chrome on Windows

* Trying to see where chrome is being installed

* useless commit because GithubActions seems to not be picking up my last commit...

* that was throwing syntax errors, so removing it

* Bump webdrivers version

* Process with args and shell: true is not supported on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing compilation error on Windows. crystal-loot/selenium.cr
2 participants
@jwoertink @zw963