Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hevm to 0.50.1 #884

Merged
merged 6 commits into from
Jan 3, 2023
Merged

Update hevm to 0.50.1 #884

merged 6 commits into from
Jan 3, 2023

Conversation

arcz
Copy link
Member

@arcz arcz commented Dec 31, 2022

This also updates dependencies and GHC to 9.2

@@ -107,34 +109,23 @@ data GenDict = GenDict { _pSynthA :: Float
-- ^ Default seed to use if one is not provided in EConfig
, _rTypes :: Text -> Maybe AbiType
-- ^ Return types of any methods we scrape return values from
, _dictValues :: Set W256
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add more context, I profiled tests and computing dictValues was a major bottleneck, it's worth having them cached as a Set where we can take random elements quickly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a line before with a comment like the other ones, and this is ready to go.

@ggrieco-tob ggrieco-tob merged commit 2a4d3c6 into master Jan 3, 2023
@ggrieco-tob ggrieco-tob deleted the hevm-0.50.1 branch January 3, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants