Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to use the google protobuf field mask #144

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Sep 8, 2021

API changes for cs3org/reva#2001 (comment)

blocked by cs3org/cs3apis-build#14

with the cs3apis-build PR I was able to build the protobuf and go with:

docker run -v /path/to/cs3apis:/root/cs3apis -v /path/to/cs3apis-build/cs3apis-build:/usr/local/bin/cs3apis-build cs3org/cs3apis cs3apis-build -build-proto
docker run -v /path/to/cs3apis:/root/cs3apis -v /path/to/cs3apis-build/cs3apis-build:/usr/local/bin/cs3apis-build cs3org/cs3apis cs3apis-build -build-go

See cs3org/go-cs3apis#44

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

use received share

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
Copy link
Contributor Author

butonic commented Oct 1, 2021

@ishank011 ci is green, the changes caused by the API change are fully implemented in cs3org/reva#2121

@labkode
Copy link
Member

labkode commented Oct 4, 2021

@butonic looks good, let's give it a try

@labkode labkode merged commit b33d276 into cs3org:main Oct 4, 2021
@butonic butonic deleted the addmountpoint branch October 4, 2021 11:27
@butonic
Copy link
Contributor Author

butonic commented Oct 4, 2021

I'll update cs3org/reva#2121 to use the upstream go-cs3org repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants