fix initialization of shares json file

Signed-off-by: David Christofas <dchristofas@owncloud.com>
cs3org · Jul 6, 2020 · 3ea2fc5 · 3ea2fc5
1 parent 6e75598
commit 3ea2fc5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/changelog/unreleased/fix-json-sharemanager-initialization.md b/changelog/unreleased/fix-json-sharemanager-initialization.md
@@ -0,0 +1,8 @@
+Bugfix: Fix initialization of json share manager
+
+When an empty shares.json file existed the json share manager would fail while
+trying to unmarshal the empty file.
+
+https://github.com/cs3org/reva/issues/941
+https://github.com/cs3org/reva/pull/940
+
diff --git a/pkg/share/manager/json/json.go b/pkg/share/manager/json/json.go
@@ -70,8 +70,8 @@ func New(m map[string]interface{}) (share.Manager, error) {
 }
 
 func loadOrCreate(file string) (*shareModel, error) {
-	_, err := os.Stat(file)
-	if os.IsNotExist(err) {
+	info, err := os.Stat(file)
+	if os.IsNotExist(err) || info.Size() == 0 {
 		if err := ioutil.WriteFile(file, []byte("{}"), 0700); err != nil {
 			err = errors.Wrap(err, "error opening/creating the file: "+file)
 			return nil, err